feat: #38 add loaders and error handling to Profile and Badge list#94
Merged
joelamouche merged 3 commits intoTheSoftwareDevGuild:mainfrom Oct 11, 2025
Conversation
yash-1104github
requested review from
Teddy1792,
joelamouche and
oscarwroche
as code owners
joelamouche
requested changes
Oct 5, 2025
Contributor
joelamouche
left a comment
joelamouche
left a comment
There was a problem hiding this comment.
Overall great work!
This still looks a bit unfriendly. We should always display "An error occurred, Please try again later or contact support on discord" in yellow with a yellow warning sign. Devs will read error messages from the logs.
Thanks in advance!
Author
|
@joelamouche Okay , I'll Update it. |
yash-1104github
force-pushed
the
Improve-loading-UX-for-lists-#38
branch
from
41d3d0b to
bb48f63
Compare
Contributor
|
@yash-1104github I think you forgot to run npm i and commit lock file, which is why CI is failing. Also while you are at it it would be lovely if you could refactor out into separate display-error component into component/display-error folder, since they are reused in different files Thanks in advance! |
Author
|
Okay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Add real loaders and error handling for Profile and Badge lists
Solve Issue - #38
Changes include:
Implemented real loader components for both Profile and Badge lists using react lucide icon.
Display an error message when fetching data fails or the list is empty.
Styled components using Tailwind CSS for consistent UI.
Benefits:
Users now see a meaningful loader instead of placeholder content.
Errors and empty states are clearly communicated, improving usability.